cameronlee314 commented on a change in pull request #1558: URL: https://github.com/apache/samza/pull/1558#discussion_r754704863
########## File path: samza-core/src/main/java/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.java ########## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.metrics.reporter; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; +import com.google.common.util.concurrent.ThreadFactoryBuilder; +import org.apache.samza.SamzaException; +import org.apache.samza.config.ShellCommandConfig; +import org.apache.samza.metrics.Counter; +import org.apache.samza.metrics.Gauge; +import org.apache.samza.metrics.MetricsReporter; +import org.apache.samza.metrics.MetricsVisitor; +import org.apache.samza.metrics.ReadableMetricsRegistry; +import org.apache.samza.metrics.MetricsRegistryWithSource; +import org.apache.samza.metrics.Timer; +import org.apache.samza.serializers.Serializer; +import org.apache.samza.system.OutgoingMessageEnvelope; +import org.apache.samza.system.SystemProducer; +import org.apache.samza.system.SystemStream; +import org.apache.samza.util.Clock; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * MetricsSnapshotReporter is a generic metrics reporter that sends metrics to a stream. + * + * jobName // my-samza-job + * jobId // an id that differentiates multiple executions of the same job + * taskName // container_567890 + * host // eat1-app128.gird + * version // 0.0.1 + * blacklist // Regex of metrics to ignore when flushing + */ +public class MetricsSnapshotReporter implements MetricsReporter, Runnable { + private static final Logger LOG = LoggerFactory.getLogger(MetricsSnapshotReporter.class); + + private final SystemProducer producer; + private final SystemStream out; + private final int reportingInterval; + private final String jobName; + private final String jobId; + private final String containerName; + private final String version; + private final String samzaVersion; + private final String host; + private final Serializer<MetricsSnapshot> serializer; + private final Optional<String> blacklist; Review comment: I like the idea of `Pattern`. I would like to stick with `Optional` though for the "no filter" case since it is a more explicit indication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
