rmatharu commented on a change in pull request #1566:
URL: https://github.com/apache/samza/pull/1566#discussion_r763249189
##########
File path:
samza-core/src/main/java/org/apache/samza/metrics/reporter/MetricsHeader.java
##########
@@ -39,6 +41,10 @@
private final String jobId;
private final String containerName;
private final String execEnvironmentContainerId;
+ /**
+ * This is optional for backwards compatibility. It was added added after
the initial version of this class.
+ */
+ private final Optional<String> execEnvironmentAttemptId;
Review comment:
nit: should we call it
exec-env-job-attempt-id
or
job-attempt-id
or
samzaEpochId (since it matches the ENV variable's name)
##########
File path:
samza-core/src/main/java/org/apache/samza/metrics/reporter/MetricsHeader.java
##########
@@ -21,13 +21,15 @@
import java.util.HashMap;
import java.util.Map;
import java.util.Objects;
+import java.util.Optional;
public class MetricsHeader {
private static final String JOB_NAME = "job-name";
private static final String JOB_ID = "job-id";
private static final String CONTAINER_NAME = "container-name";
private static final String EXEC_ENV_CONTAINER_ID = "exec-env-container-id";
+ private static final String EXEC_ENV_ATTEMPT_ID = "exec-env-attempt-id";
Review comment:
nit: should we call it
exec-env-job-attempt-id
or
job-attempt-id
or
samzaEpochId (since it matches the ENV variable's name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
