ajothomas commented on a change in pull request #1560:
URL: https://github.com/apache/samza/pull/1560#discussion_r787182661



##########
File path: 
samza-api/src/main/java/org/apache/samza/table/AsyncReadWriteTable.java
##########
@@ -90,6 +91,27 @@
    */
   CompletableFuture<Void> putAllAsync(List<Entry<K, V>> entries, Object ... 
args);
 
+  /**
+   * Asynchronously updates an existing record for a given key with the 
specified update.
+   *
+   * @param key the key with which the specified {@code value} is to be 
associated.
+   * @param update the update applied to the record associated with a given 
{@code key}.
+   * @param args additional arguments
+   * @throws NullPointerException if the specified {@code key} is {@code null}.
+   * @return CompletableFuture for the operation
+   */
+  CompletableFuture<Void> updateAsync(K key, U update, Object ... args);

Review comment:
       `UpdateOptions` is a parameter which defines how the platform would 
handle updates and we are currently using it within the operator implementation 
only. 
   Any `updateAsync` call would eventually be delegated to 
`TableWriteFunction`'s `updateAsync` method which is defined by the user for 
their table integrations. I don't see the use of UpdateOptions beyond the 
operator right now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to