rayman7718 commented on a change in pull request #1580:
URL: https://github.com/apache/samza/pull/1580#discussion_r809595687
##########
File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
##########
@@ -250,6 +285,40 @@ private void runTasks(IncomingMessageEnvelope envelope) {
}
}
+ /**
+ * when elasticity is not enabled, fetch the workers from
sspToTaskWorkerMapping using envelope.getSSP()
+ * when elasticity is enabled,
+ * sspToTaskWorkerMapping has workers for a SSP which has keyBucket
+ * hence need to use envelop.getSSP(elasticityFactor)
+ * Additionally, when envelope is EnofStream, it needs to be sent to
all works for the ssp irrespective of keyBucket
Review comment:
Could we list out all the message-types that map to more than one workes
e.g., EOS, watermark, etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
