dxichen commented on code in PR #1595:
URL: https://github.com/apache/samza/pull/1595#discussion_r842032504
##########
samza-core/src/main/java/org/apache/samza/storage/blobstore/index/DirIndex.java:
##########
@@ -48,6 +51,12 @@ public DirIndex(String dirName,
Preconditions.checkNotNull(filesRemoved);
Preconditions.checkNotNull(subDirsPresent);
Preconditions.checkNotNull(subDirsRemoved);
+ // check to validate that a file is not present in file removed and file
present list
Review Comment:
When could this happen? What scenario are we defending against?
Nit: s/check/Check
##########
samza-core/src/main/java/org/apache/samza/storage/blobstore/index/DirIndex.java:
##########
@@ -173,4 +182,5 @@ public String toString() {
'}';
}
}
+
Review Comment:
Remove extra line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
