rmatharu commented on code in PR #1603:
URL: https://github.com/apache/samza/pull/1603#discussion_r864336033


##########
samza-core/src/test/java/org/apache/samza/serializers/model/TestSamzaObjectMapper.java:
##########
@@ -279,6 +279,28 @@ public void testDeserializeSystemStreamPartition() throws 
IOException {
     assertEquals(ssp, deserSSP);
   }
 
+  @Test
+  public void testSerdeSystemStreamPartitionKey() throws IOException {

Review Comment:
   Could we add a test, that checks if new SamzaObjectMapper is able to 
deserialize serialized data written by old SamzaObjectMapper, 
   and 
   vice versa (Old SamzaObjectMapper is able to "handle" data written by new 
SamzaObjectMapper) -- for this one if no test is feasible, just a manual 
verification for now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to