ajothomas commented on code in PR #1616:
URL: https://github.com/apache/samza/pull/1616#discussion_r930392479
##########
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java:
##########
@@ -34,14 +34,15 @@
public class RunLoopFactory {
private static final Logger log =
LoggerFactory.getLogger(RunLoopFactory.class);
- public static Runnable
createRunLoop(scala.collection.immutable.Map<TaskName, RunLoopTask>
taskInstances,
+ public static RunLoop createRunLoop(scala.collection.immutable.Map<TaskName,
RunLoopTask> taskInstances,
Review Comment:
The reason for the change is that currently the `RunLoop` is only a
`Runnable` in the`SamzaContainer`. We need to be able to set the `RunLoop` to
drain mode by calling it's `drain` method from `SamzaContainer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
