james-deee commented on code in PR #1628: URL: https://github.com/apache/samza/pull/1628#discussion_r949607846
########## samza-shell/src/main/bash/run-class.sh: ########## @@ -153,7 +153,7 @@ fi [[ $JAVA_OPTS != *-Xmx* ]] && JAVA_OPTS="$JAVA_OPTS -Xmx768M" # Check if the GC related flags are specified. If not - add the respective flags to JVM_OPTS. -[[ $JAVA_OPTS != *PrintGCDateStamps* && $JAVA_OPTS != *-Xloggc* ]] && JAVA_OPTS="$JAVA_OPTS -XX:+PrintGCDateStamps -Xloggc:$SAMZA_LOG_DIR/gc.log" +[[ $JAVA_OPTS != *-Xloggc* ]] && JAVA_OPTS="$JAVA_OPTS -Xloggc:$SAMZA_LOG_DIR/gc.log" Review Comment: PrintGCDateStamps is removed from Java11, so just removing it from here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
