prateekm commented on code in PR #1650:
URL: https://github.com/apache/samza/pull/1650#discussion_r1092601390
##########
samza-core/src/main/java/org/apache/samza/storage/blobstore/util/BlobStoreUtil.java:
##########
@@ -629,4 +637,15 @@ private static Predicate<Throwable> isCauseNonRetriable() {
return unwrapped != null &&
!RetriableException.class.isAssignableFrom(unwrapped.getClass());
};
}
+
+ private RetryPolicy<Object> buildRetryPolicyFromConfig() {
Review Comment:
Consider moving this method to BlobStoreConfigs and returning a
RetryPolicy/RetryPolicyConfig directly (i.e. instead of returning the configs
individually through multiple accessors and constructing this object later).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
