prateekm opened a new pull request, #1655:
URL: https://github.com/apache/samza/pull/1655
Issues: ContainerStorageManager has gotten very unwieldy with 1000+ LOC of
highly complex and invocation-order dependent logic. It also does too much by
trying to manage side inputs lifecycle along with regular state stores'.
Changes:
1. Separated side inputs (and standby) related store creation and
restore logic into a separate SideInputsManager class.
2. Separated helper methods into a ContainerStorageManagerUtil class,
and made them all static to ensure that they don't mutate class fields.
Most of the PR is simply moving code from one place to another. However a
couple of places that introduce semantic changes or otherwise require careful
review are called inline in "Refactor Note" comments.
There is a lot more room for improvement (e.g. more javadocs, more tests,
simplifying method signatures, etc). But this change should make it easier to
reason about the lifecycle of side inputs for now.
Tests: Existing ContainerStorageManager unit tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
