mynameborat opened a new pull request, #1680: URL: https://github.com/apache/samza/pull/1680
**Description**: Runloop currently takes in lot of parameters and the constructor has grown to the point where it is unmanageable with multiple overloads. Introducing new configuration requires lot of updates to existing tests and components even if the parameters have no effect on all of the usages. With this PR, we should be able to decouple different users of RunLoop and enable these components to have their own scoped config. e.g., `SideInputManager` can now have its own set of runloop parameters without having to tie itself with `TaskConfig`. **Changes**: - Introduce `RunLoopConfig`, a container object to hold all required parameters for runloop from `Config`. - Remove existing overloads of constructor - Simplify the constructor to take `RunLoopConfig` and initialize the necessary components and fields - Introduce `SideInputManagerRunLoopConfig`, an overload of `RunLoopConfig` to be used within `SideInputManager` - Modify RunLoopFactory create method signature **Tests**: - Unit test **API Changes**: - No external API change **Usage Instructions**: N.A **Upgrade Instructions**: N.A **Note**: This PR serves as foundation for SAMZA-2791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
