shekhars-li commented on code in PR #1682:
URL: https://github.com/apache/samza/pull/1682#discussion_r1297738692
##########
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManagerRestoreUtil.java:
##########
@@ -185,17 +185,6 @@ private static CompletableFuture<Map<TaskName,
Checkpoint>> restoreAllTaskInstan
throw new SamzaException(msg, ex); // wrap in unchecked
exception to throw from lambda
}
}
-
Review Comment:
@dxichen thanks for the review. Sorry I am unsure which future are you
referring to. If you meant close() -> that can't be chained because in case of
exception, if we retry the restore, the restore manager would be prematurely
closed. So we only close it if we are sure the future is complete.
If you meant something else, please let me know and I can address/clarify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
