shekhars-li commented on code in PR #1687:
URL: https://github.com/apache/samza/pull/1687#discussion_r1336424013
##########
samza-core/src/main/java/org/apache/samza/storage/blobstore/util/BlobStoreUtil.java:
##########
@@ -90,6 +92,9 @@ public class BlobStoreUtil {
private final SnapshotIndexSerde snapshotIndexSerde;
private final RetryPolicyConfig retryPolicyConfig;
+ // LRU cache for blob ids that were TTL removed
+ private final Cache<String, Object> ttlRemovedBlobIdsCache =
CacheBuilder.newBuilder().maximumSize(1000).build();
Review Comment:
Based on the metrics I checked for our jobs (some large jobs, didn't have a
way to check avg), it's around 100 blobs per minute for all the stores for a
job. So it should be able to hold about 10 mins worth of blob ids without any
dedup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
