shanthoosh commented on code in PR #1716: URL: https://github.com/apache/samza/pull/1716#discussion_r2072199051
########## samza-shell/src/main/bash/run-framework-class.sh: ########## @@ -107,10 +112,15 @@ fi # permissions for the classpath-related files when they are in their own directory. An example of where # this is helpful is when using container images which might have predefined permissions for certain # directories. -CLASSPATH_WORKSPACE_DIR=$base_dir/classpath_workspace + +# Note: When on samza-yarn, CLASSPATH_WORKSPACE_DIR looks like: +# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/classpath_workspace +CLASSPATH_WORKSPACE_DIR=$home_dir/classpath_workspace mkdir -p $CLASSPATH_WORKSPACE_DIR + # file containing the classpath string; used to avoid passing long classpaths directly to the jar command PATHING_MANIFEST_FILE=$CLASSPATH_WORKSPACE_DIR/manifest.txt + Review Comment: Would be great to log the location of manifest-file and the pathing-jar-file path. ########## samza-shell/src/main/bash/run-class.sh: ########## @@ -97,12 +108,18 @@ else fi if [ -z "$SAMZA_LOG_DIR" ]; then - SAMZA_LOG_DIR="$base_dir" + # When on samza-yarn, SAMZA_LOG_DIR will point to the symlink located at: Review Comment: Thanks for adding the comments. Please remove when on samza-yarn prefix, since this script is applicable only for yarn deployments. ########## samza-shell/src/main/bash/run-class.sh: ########## @@ -78,15 +83,21 @@ fi # permissions for the classpath-related files when they are in their own directory. An example of where # this is helpful is when using container images which might have predefined permissions for certain # directories. -CLASSPATH_WORKSPACE_DIR=$base_dir/classpath_workspace + +# Note: When on samza-yarn, CLASSPATH_WORKSPACE_DIR looks like: +# /<hadoop dir>/usercache/<linux account>/appcache/application_1745893616511_0059/container_e64_1745893616511_0059_01_002027/classpath_workspace +CLASSPATH_WORKSPACE_DIR=$home_dir/classpath_workspace mkdir -p $CLASSPATH_WORKSPACE_DIR + # file containing the classpath string; used to avoid passing long classpaths directly to the jar command PATHING_MANIFEST_FILE=$CLASSPATH_WORKSPACE_DIR/manifest.txt + # jar file to include on the classpath for running the main class PATHING_JAR_FILE=$CLASSPATH_WORKSPACE_DIR/pathing.jar Review Comment: Would be great if we can log the pathing_jar_file path and the manifest_file path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
