[ 
https://issues.apache.org/jira/browse/SAMZA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828855#comment-13828855
 ] 

Garry Turkington commented on SAMZA-77:
---------------------------------------

Made changes to KafkaConfig (not ClientUtils as the Jira says?):
https://reviews.apache.org/r/15760/

Note that KafkaSystemConsumer line 58 doesn't actually need the change:

  clientId: String = "undefined-client-id-" + UUID.randomUUID.toString,

It's using string concatenation not token replacement.  Though could be changed 
to that if consistency was important.

> ClientUtils: random client id isn't actually random
> ---------------------------------------------------
>
>                 Key: SAMZA-77
>                 URL: https://issues.apache.org/jira/browse/SAMZA-77
>             Project: Samza
>          Issue Type: Bug
>          Components: kafka
>    Affects Versions: 0.6.0
>            Reporter: Jakob Homan
>              Labels: newbie
>             Fix For: 0.7.0
>
>
> ClientUtils:94
> {code}
>   def getKafkaSystemProducerConfig(
>     systemName: String,
>     clientId: String = "undefined-samza-producer-" format 
> UUID.randomUUID.toString,{code}
> attempts to create a random kafka client but because there's no {{%s}} to 
> interpolate the random UUID, the string is actually the same and the format 
> call is actually a no-op.  Need that {{%s}}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to