[ 
https://issues.apache.org/jira/browse/SAMZA-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830075#comment-13830075
 ] 

Chris Riccomini commented on SAMZA-76:
--------------------------------------

This looks really good.

One silly thing on my part. I told you to set the DEFAULT_* values to 768. They 
should actually be 1024. Only -Xmx should be 768. The reason for this extra gap 
is to accommodate non-heap memory usage (permgen, etc), and provide a little 
buffer for the process to use some page cache.

I think if we make this tweak, and you can verify that the hello-samza project 
works with these changes, we should be good to go.

> Improve default memory settings for samza tasks
> -----------------------------------------------
>
>                 Key: SAMZA-76
>                 URL: https://issues.apache.org/jira/browse/SAMZA-76
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Rekha Joshi
>            Priority: Minor
>         Attachments: SAMZA_76.patch, SAMZA_76_1.patch, SAMZA_76_2.patch
>
>
> The {{run-class.sh}} script hardcodes the xmx setting for the launched class 
> at 160M.  This is generally too low, and should be bumped up, but should also 
> be specified in a more overridable-friendly way via an environmental variable.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to