Chris Riccomini created SAMZA-98:
------------------------------------
Summary: ReadableCollector uses both var and mutable for envelopes
Key: SAMZA-98
URL: https://issues.apache.org/jira/browse/SAMZA-98
Project: Samza
Issue Type: Bug
Components: container
Affects Versions: 0.6.0
Reporter: Chris Riccomini
Fix For: 0.7.0
The ReadableCollector collector class declares a variable called envelopes,
which is both a var (not val), and also a mutable.ArrayBuffer. Typically,
mutable array buffers should be vals. Conversely, var variables should be
immutable.
My vote is to make the envelopes variable a val, and keep it a
mutable.ArrayBuffer. This variable is used a lot, and keeping a mutable array
buffer should (theoretically) result in less garbage in the heap.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
