[ 
https://issues.apache.org/jira/browse/SAMZA-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841853#comment-13841853
 ] 

Chris Riccomini commented on SAMZA-38:
--------------------------------------

Hmm. The two patches look identical. The new one still doesn't seem to actually 
rename run-task.sh to run-container.sh. That is, if I apply the patch, and do 
an 'ls' of ./samza-shell/src/main/ I still see:

{noformat}
./samza-shell/src/main/bash
./samza-shell/src/main/bash/run-am.sh
./samza-shell/src/main/bash/run-task.sh
./samza-shell/src/main/bash/kill-yarn-job.sh
./samza-shell/src/main/bash/run-job.sh
./samza-shell/src/main/bash/run-class.sh
{noformat}

I would have expected to see run-container.sh.

> Rename run-task.sh to run-container.sh
> --------------------------------------
>
>                 Key: SAMZA-38
>                 URL: https://issues.apache.org/jira/browse/SAMZA-38
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Rekha Joshi
>              Labels: newbie
>         Attachments: SAMZA-38.0.patch, SAMZA-38.1.patch
>
>
> We should rename run-task.sh to run-container.sh, since that's what it does. 
> ShellCommandConfig will need to be updated. Should run a grep through the 
> codebase to find any other mentions, as well.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to