[ 
https://issues.apache.org/jira/browse/SAMZA-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843509#comment-13843509
 ] 

Jakob Homan commented on SAMZA-103:
-----------------------------------

+1. I believe one can do this with a structural replace in IntelliJ.  Probably 
would have a higher confidence of correct changes, though would still require a 
giant patch.  It's unfortunate we don't have 2.10 yet: 
http://docs.scala-lang.org/overviews/core/string-interpolation.html

> Change string concatenation style
> ---------------------------------
>
>                 Key: SAMZA-103
>                 URL: https://issues.apache.org/jira/browse/SAMZA-103
>             Project: Samza
>          Issue Type: Bug
>          Components: container, kafka, kv, test, yarn
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>
> Most of Samza's logging and output uses the style:
> {code}
> warn("Some error for %s happened." format (myVar))
> {code}
> This style is actually really problematic because it leads to runtime 
> exceptions in cases where there is an extra %s or there was a %d when it 
> should have been a %s.
> I think we should switch everything over to the standard Java style:
> {code}
> warn("Some error for " + myVar + " happened.")
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to