[
https://issues.apache.org/jira/browse/SAMZA-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Riccomini updated SAMZA-114:
----------------------------------
Attachment: SAMZA-114.0.patch
Attaching patch. RB at https://reviews.apache.org/r/16606/.
1. Removed TestUtil in samza-test.
2. Added TestUtil.expect to already-existing TestUtil in samza-core.
3. Updated build.gradle to make samza-kv depend on samza-core, not samza-test.
The cycle is now brokern. I re-ran ./gradlew eclipse, and Eclipse is much
happier now.
The only slightly odd thing about this patch is that TestUtil is actually a
test for the Util class. Should be fine, though.
> Fix cyclic dependencies in build.gradle
> ---------------------------------------
>
> Key: SAMZA-114
> URL: https://issues.apache.org/jira/browse/SAMZA-114
> Project: Samza
> Issue Type: Bug
> Components: build
> Affects Versions: 0.6.0
> Reporter: Chris Riccomini
> Assignee: Chris Riccomini
> Attachments: SAMZA-114.0.patch
>
>
> SAMZA-111 introduced a cyclic dependency between samza-kv and samza-test.
> samza-kv depends on samza-test for TestUtil.expect, and sama-test depends on
> samza-kv to do some testing. Gradle handles this fine, but Eclipse is not
> happy about it. It's not a good practice, in general, and we should fix it.
> I think the easiest fix is to just move the TestUtil object into samza-core's
> TestUtil class, which already exists.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
