[
https://issues.apache.org/jira/browse/SAMZA-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866820#comment-13866820
]
Chris Riccomini commented on SAMZA-125:
---------------------------------------
Looks good. Two things:
1. Minor nit: the indentation is kind of wonky in bootstrap and on the exit 0
line in the bootstrap if statement. Could you double space everything to keep
it standard?
2. Could you send a pull request for hello-samza via Github, and I'll just
merge in the script-changes over there?
> Change HelloSamza grid script defaults and add 'all' options
> ------------------------------------------------------------
>
> Key: SAMZA-125
> URL: https://issues.apache.org/jira/browse/SAMZA-125
> Project: Samza
> Issue Type: Improvement
> Reporter: Garry Turkington
> Assignee: Garry Turkington
> Priority: Minor
> Attachments: grid-docs-changes.patch, grid-script-changes.patch
>
>
> The HelloSamza bin/grid script by default bootstraps the system, potentially
> blowing away an existing install.
> This can be changed to make the default no-args behaviour to show the help
> and add a new "bootstrap" option.
> Also saves typing by adding "start all", "stop all" and "install all" options.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
