[
https://issues.apache.org/jira/browse/SAMZA-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869774#comment-13869774
]
Chris Riccomini commented on SAMZA-128:
---------------------------------------
This looks really good. A few comments/questions:
1. Can you post the diff as a patch here, as well? This is what actually
assigns the rights to Apache.
2. I tried running the tests, but I'm having problems. I did a build of Kafka
2.10, and put the 0.8.1 jars in the samza-kafka/lib directory (named
kafka_2.10-0.8.0-SNAPSHOT.jar and kafka_2.10-0.8.0-SNAPSHOT-tes.jar), but
Gradle seems to be ignoring them. I get compilation errors when I run
`-PscalaVersion=2.10 clean test`. Tests for 2.8.1 and 2.9.2 pass. What are the
steps you followed to get the Kafka jars to work for tests?
3. Should we use scalaLibVersion for the Kafka dependencies in build.gradle
instead of scalaVersion? I think this is technically the format that SBT builds.
> Scala 2.10 support
> ------------------
>
> Key: SAMZA-128
> URL: https://issues.apache.org/jira/browse/SAMZA-128
> Project: Samza
> Issue Type: Improvement
> Reporter: Dan Di Spaltro
>
> Support Scala 2.10.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
