[ 
https://issues.apache.org/jira/browse/SAMZA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Riccomini updated SAMZA-134:
----------------------------------

    Attachment: SAMZA-134.0.patch

Attaching a patch. RB at https://reviews.apache.org/r/17193

1. Clean up a metric name in KafkaSystemConsumerMetrics that I thought was 
confusing. Switched from "reads" to "messages-read", and from "skipped-reads" 
to "skipped-fetch-requests". Before, it was unclear to me if reads = fetch 
requests, or fetch response with message in it.
2. Added a per-system-stream counter in SystemConsumers called 
"messages-chosen". Counter is incremented for the appropriate SystemStream 
every time the chooser picks a non-null message.

Verified that the metric exists and is incremented properly using JMX and 
hello-samza.

> Add container-level messages/stream metric
> ------------------------------------------
>
>                 Key: SAMZA-134
>                 URL: https://issues.apache.org/jira/browse/SAMZA-134
>             Project: Samza
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Chris Riccomini
>         Attachments: SAMZA-134.0.patch
>
>
> We currently offer the following messages/sec metrics:
> 1. Messages/sec per-container.
> 2. Messages/sec per-SystemStreamPartition for KafkaSystemConsumer.
> We don't offer messages/sec per SystemStream. This metric is useful in cases 
> you want to know the total messages processed for a stream in a single 
> container, especially in cases where a single container is processing all 
> partitions for a stream.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to