[
https://issues.apache.org/jira/browse/SAMZA-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906177#comment-13906177
]
ASF GitHub Bot commented on SAMZA-47:
-------------------------------------
Github user ept commented on a diff in the pull request:
https://github.com/apache/incubator-samza/pull/1#discussion_r9885664
--- Diff:
samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala
---
@@ -27,17 +27,32 @@ import java.io._
import java.util.Iterator
import java.lang.Iterable
import org.apache.samza.config.Config
-import grizzled.slf4j.Logging
+import org.apache.samza.container.SamzaContainerContext
+import grizzled.slf4j.{Logger, Logging}
object LevelDbKeyValueStore {
- def options(config: Config) = {
+ private lazy val logger = Logger(classOf[LevelDbKeyValueStore])
+
+ def options(config: Config, containerContext: SamzaContainerContext) = {
--- End diff --
I also got caught out by that one. The config here isn't the entire job
config, but only the subset of the config for that particular store -- so if we
don't pass in that subset config, we'd still have to at least pass in the store
name so that LevelDbKeyValueStore knows which store we're talking about. I
thought it would be better to continue passing in the subset of the config
instead.
Perhaps we should call the parameter `storeConfig` to prevent such
confusion?
> LevelDB and L1 cache use the same configuration value in KeyValueStorageEngine
> ------------------------------------------------------------------------------
>
> Key: SAMZA-47
> URL: https://issues.apache.org/jira/browse/SAMZA-47
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Jay Kreps
> Assignee: Martin Kleppmann
>
> Both seem to key off of
> cache.size
> This is not right. The L1 cache is caching a number of objects and leveldb is
> allocating a number of bytes. In general the leveldb cache should be big
> (tens of MBs) and the L1 cache small (a few thousand).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
