[
https://issues.apache.org/jira/browse/SAMZA-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962021#comment-13962021
]
Martin Kleppmann commented on SAMZA-223:
----------------------------------------
Clock is an interface, SystemClock is a class which implements that interface
using System.currentTimeMillis. Are you saying we should get rid of the
interface, and only have a class? That would still be ok from a testability
point of view, but I thought keeping the Clock in samza-api as an interface
would be good from the point of view of minimizing the amount of stuff in
samza-api.
> Add a cache for stream metadata
> -------------------------------
>
> Key: SAMZA-223
> URL: https://issues.apache.org/jira/browse/SAMZA-223
> Project: Samza
> Issue Type: Improvement
> Reporter: Martin Kleppmann
> Assignee: Martin Kleppmann
> Attachments: SAMZA-223.1.patch
>
>
> As part of SAMZA-179 I wrote a cache to reduce the number of calls to
> SystemAdmin.getSystemStreamMetadata (which go to the broker). It's currently
> unclear whether we still want to use the stream metadata to determine whether
> a task is caught up, so I've split the StreamMetadataCache out of SAMZA-179,
> and made it a standalone patch. This patch doesn't contain any of the job
> shutdown stuff, only the metadata caching.
> Admittedly there's less of a need for this cache if we're not requesting
> stream metadata within tasks, so perhaps we should just throw this code away.
> But it may also be useful, and certainly shouldn't do any harm. What do you
> think?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
