[ 
https://issues.apache.org/jira/browse/SAMZA-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986741#comment-13986741
 ] 

Sriram Subramanian commented on SAMZA-123:
------------------------------------------

1. Naming. I understand that your naming was focussed on the partition grouping 
rather than who owns the partitions. If the grouping could be freely moved 
between tasks then I agree it should have a different name to avoid confusion. 
However, this is not possible. The task does represent the grouping of 
partitions and hence it is better for them to be tightly coupled. Task id / 
name seems to be more appropriate to indicate that.
2. I am still not all in with making the grouping api public. The main reason 
is that it encourages anyone to write a grouping implementation that reassigns 
partitions to tasks and the behavior is undefined. We can definitely catch 
these cases and warn or error but I think that is not a great user experience. 
However, I am willing to experiment here since there seems to be a consensus on 
this.


> Move topic partition grouping to the AM and generalize
> ------------------------------------------------------
>
>                 Key: SAMZA-123
>                 URL: https://issues.apache.org/jira/browse/SAMZA-123
>             Project: Samza
>          Issue Type: Sub-task
>          Components: container
>    Affects Versions: 0.6.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: SAMZA-123-design-doc.md, SAMZA-123-design-doc.pdf
>
>
> Currently the AM sends a set of all the topics and partitions to the 
> container, which then groups them by partition and assigns each set to a task 
> instance. By moving the grouping to the AM, we can assign arbitrary groups to 
> task instances, which will allow more partitioning strategies, as discussed 
> in SAMZA-71.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to