[
https://issues.apache.org/jira/browse/SAMZA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019185#comment-14019185
]
Martin Kleppmann commented on SAMZA-274:
----------------------------------------
Quoting [~criccomini] on SAMZA-224:
bq. I thought I'd opened up a JIRA for the apply() refactor, but I can't find
it anymore. We need to break that code up. My thought was to just have smaller
apply() methods for each individual class (effectively treating the companion
object like a factory). This is how the DefaultChooser is wired up, and I think
it works fairly well.
> Refactor SamzaController and improve test coverage
> --------------------------------------------------
>
> Key: SAMZA-274
> URL: https://issues.apache.org/jira/browse/SAMZA-274
> Project: Samza
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Martin Kleppmann
> Fix For: 0.8.0
>
>
> SamzaController would benefit from refactoring, to split the very long
> methods into shorter ones, and separating out concerns better.
> In the process, we should also make it more testable, and write more tests.
> It currently only has two tests. Amongst other things, we should make sure
> that we're testing for the issue that was fixed in SAMZA-142 (test coverage
> that we lost in SAMZA-224).
> If appropriate, the unit tests can start covering aspects of integration
> tests like TestStatefulTask, but in a more focussed manner.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
