[
https://issues.apache.org/jira/browse/SAMZA-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056719#comment-14056719
]
Chinmay Soman commented on SAMZA-326:
-------------------------------------
Well, that's going to make things difficult for me.
The reason I had to fix it in here is because I"m using the same test suite for
both LevelDb and In-memory (as it should be). With LevelDb and In-memory
implementations having 2 different semantics for 'range', testing becomes
extremely difficult.
I'm more than happy to make an explicit commit to 0.7.1 branch. Thoughts ?
> LevelDbKeyValueStore range implements 'from' -> 'to' instead of 'from' ->
> 'until'
> ---------------------------------------------------------------------------------
>
> Key: SAMZA-326
> URL: https://issues.apache.org/jira/browse/SAMZA-326
> Project: Samza
> Issue Type: Bug
> Components: kv
> Affects Versions: 0.7.0
> Reporter: Chinmay Soman
> Fix For: 0.8.0, 0.7.1
>
>
> Most built-in ordered collection data structures in Java (SortedMap, List,
> ...) define a range (submap / sublist) as follows:
> 'from' (inclusive) -> 'until' (exclusive)
> However, the current LevelDbKeyValueStore implementation defines range as:
> 'from' (inclusive) -> 'to' (inclusive)
> While this is not technically incorrect, I think we should change the
> semantics to follow the norm.
> P.S. This can easily be done by changing the '<=' comparison in
> LevelDbRangeIterator to '<'
--
This message was sent by Atlassian JIRA
(v6.2#6252)
