[
https://issues.apache.org/jira/browse/SAMZA-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106595#comment-14106595
]
Yan Fang commented on SAMZA-361:
--------------------------------
Hi Chris, thank you for the reviewing. Since I made a few changes, could you
take a look at it ?
RB: https://reviews.apache.org/r/24917/diff/2-3/
* add the slf4j-api dependency
* change using Logger in grizziled to using trail Logging. ( I feel it should
be fine. )
* add brace for one line condition statement
Thank you.
> Remove Grizzled SLF4J
> ---------------------
>
> Key: SAMZA-361
> URL: https://issues.apache.org/jira/browse/SAMZA-361
> Project: Samza
> Issue Type: Bug
> Components: container
> Affects Versions: 0.8.0
> Reporter: Chris Riccomini
> Assignee: Yan Fang
> Fix For: 0.8.0
>
> Attachments: SAMZA-361.1.patch, SAMZA-361.patch
>
>
> The cons of Grizzled SLF4J outweigh the pros. We can [create a single
> class|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/utils/Logging.scala]
> that does what we need for logging. Eliminating the Grizzled dependency
> means that we'll have one less Scala binary to depend on. It will also give
> us more control over SLF4J APis that we might want to use (e.g. the
> [MDC|http://www.slf4j.org/api/org/slf4j/MDC.html], see SAMZA-310).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
