[ 
https://issues.apache.org/jira/browse/SAMZA-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Riccomini updated SAMZA-403:
----------------------------------
    Attachment: SAMZA-403.hello-samza.2.patch

Attaching updated patch. I tested your patch locally and found a few issues. 
Things I changed:

# Removed sonatype repo. Appears we no longer need it. Was causing problems 
with irclib, as well.
# Removed some of the assembly includes that were redundant, since they'd get 
pulled in via transitive dependencies.
# Renamed the org/name properties to be org.apache.samza:hello-samza.
# Update RAT excludes to exclude **/target/** and .project.

I also noticed that the build is pretty slow now, for some reason. It seems to 
pause for quite a while during this step:

{noformat}
[INFO] Reading assembly descriptor: src/main/assembly/src.xml
{noformat}

I attached via VisualVM, and it's spending 100% of CPU cycles looking at file 
permissions through some Java7 reflector class thing. Seems as though it could 
be some weirdness between Java 8, which I'm running, Maven 3, and the assembly 
plugin.

If this all looks good to you, I'll commit it.

> Consolidate hello-samza example job in one project
> --------------------------------------------------
>
>                 Key: SAMZA-403
>                 URL: https://issues.apache.org/jira/browse/SAMZA-403
>             Project: Samza
>          Issue Type: Improvement
>          Components: hello-samza
>            Reporter: David Chen
>            Assignee: David Chen
>         Attachments: SAMZA-403.0.patch, SAMZA-403.hello-samza.1.patch, 
> SAMZA-403.hello-samza.2.patch, SAMZA-403.hello-samza.patch
>
>
> Currently, hello-samza contains two subprojects:
>  * samza-wikipedia - contains the implementation for the jobs and the 
> Wikipedia system
>  * samza-job-package - contains the job configs and assembly
> AFAIK, there is no particular reason why these should live in different 
> subprojects and thus should be merged into a single (sub)project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to