[ 
https://issues.apache.org/jira/browse/SAMZA-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276268#comment-14276268
 ] 

Chris Riccomini commented on SAMZA-479:
---------------------------------------

bq. 1. Is the only difference between new LogingEvent and the original 
LoggingEvent "subAppend" part, which gives the logging messages format?

Yea, that was my intention.

bq. Which one doe you mean?

I meant your first bullet point.

{code}
LoggingEventAvroSerde implements Serde<LoggingEvent> {
  public void toBytes(LoggingEvent e) { /* encode as Avro record */ }
  public LoggingEvent fromBytes(byte[] bytes) { /* construct logging event from 
Avro record */ }
}
{code}

It's up to the receiving side how they want to handle it. I think out of the 
box, we shouldn't worry about Avro. We'll definitely need a 
LoggingEventStringSerde, which should just extend StringSerde, and use 
LoggingEvent.getMessage. LoggingEventJsonSerde, which could (de)encode the 
LoggingEvent to/from a HashMap, would be nice to have as well, but not required.

> Make StreamAppender pluggable for different log formats
> -------------------------------------------------------
>
>                 Key: SAMZA-479
>                 URL: https://issues.apache.org/jira/browse/SAMZA-479
>             Project: Samza
>          Issue Type: Improvement
>    Affects Versions: 0.9.0
>            Reporter: Yan Fang
>            Assignee: Yan Fang
>             Fix For: 0.9.0
>
>
> Currently the StreamAppender only accepts String and sends String as the 
> format for all the logs. It will be useful to have StreamAppender to accept 
> and send other formats, such as Avro, JSON, etc. So the idea is to move the 
> encoding of the LoggingEvent to a serde.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to