[incubator-sdap-mudrod] branch master updated: SDAP-199 equals() is used for java.lang.Integer instead of == or !=, because it is not comparing actual value but locations in memory. (#47)

[lewismc]

This is an automated email from the ASF dual-hosted git repository.

lewismc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-sdap-mudrod.git


The following commit(s) were added to refs/heads/master by this push:
     new 32f7923  SDAP-199 equals() is used for java.lang.Integer instead of == 
or !=, because it is not comparing actual value but locations in memory. (#47)
32f7923 is described below

commit 32f79236b7cf955152d3f26b03cacd5def66ccbc
Author: Furkan KAMACI <furkankam...@gmail.com>
AuthorDate: Wed Aug 7 02:05:33 2019 +0300

    SDAP-199 equals() is used for java.lang.Integer instead of == or !=, 
because it is not comparing actual value but locations in memory. (#47)
---
 .../sdap/mudrod/recommendation/structure/PODAACMetadataFeature.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/core/src/main/java/org/apache/sdap/mudrod/recommendation/structure/PODAACMetadataFeature.java
 
b/core/src/main/java/org/apache/sdap/mudrod/recommendation/structure/PODAACMetadataFeature.java
index 541c166..8a5e8b3 100644
--- 
a/core/src/main/java/org/apache/sdap/mudrod/recommendation/structure/PODAACMetadataFeature.java
+++ 
b/core/src/main/java/org/apache/sdap/mudrod/recommendation/structure/PODAACMetadataFeature.java
@@ -289,7 +289,7 @@ public class PODAACMetadataFeature extends MetadataFeature {
     // TODO Auto-generated method stub
     for (String variable : featureTypes.keySet()) {
       Integer type = featureTypes.get(variable);
-      if (type != VAR_CATEGORICAL) {
+      if (!type.equals(VAR_CATEGORICAL)) {
         continue;
       }
 
@@ -329,7 +329,7 @@ public class PODAACMetadataFeature extends MetadataFeature {
     // TODO Auto-generated method stub
     for (String variable : featureTypes.keySet()) {
       Integer type = featureTypes.get(variable);
-      if (type != VAR_ORDINAL) {
+      if (!type.equals(VAR_ORDINAL)) {
         continue;
       }