leo65535 commented on pull request #1027: URL: https://github.com/apache/incubator-seatunnel/pull/1027#issuecomment-1010714013
> > > Hi, `.gitkeep` is for placeholders, since we can't commit empty folders. > > > > > > Make sense, we can keep it, or we can put a `README.md` in this folder. > > > `seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think? > > > > > > We introduced a `seatunnel-example` module, so this file seems useless. > > > > Hi, `.gitkeep` is for placeholders, since we can't commit empty folders. > > > > > > Make sense, we can keep it, or we can put a `README.md` in this folder. > > > `seatunnel-demo.json` seems to be for a simple example, can we keep it for now? What do you think? > > > > > > We introduced a `seatunnel-example` module, so this file seems useless. > > I suggest we keep it, it is necessary to keep an example here. This is where users need to care about configuration. If you don't keep it, you also need to submit a `.gitkeep`, we will use this path to parse the user's configuration file. OK, let's keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
