CalvinKirs commented on issue #965:
URL: 
https://github.com/apache/incubator-seatunnel/issues/965#issuecomment-1020791998


   > If you want to see how Meter APIs are designed in SkyWalking, these two 
are good
   > 
   > 1. Source codes, 
https://github.com/apache/skywalking-java/blob/main/apm-application-toolkit/apm-toolkit-meter/src/main/java/org/apache/skywalking/apm/toolkit/meter/MeterFactory.java
   > 2. APIs docs, 
https://skywalking.apache.org/docs/skywalking-java/v8.8.0/en/setup/service-agent/java-agent/application-toolkit-meter/
   > 
   > Also, Prometheus APIs should be a good reference(but Java's Prometheus 
APIs are not very widely used). MicroMeter(Sleuth) APIs are good too. 
SkyWalking's APIs could adopt Sleuth APIs to meter APIs. 
https://skywalking.apache.org/docs/skywalking-java/v8.8.0/en/setup/service-agent/java-agent/application-toolkit-micrometer/
   > 
   > __
   > 
   > The reason for sharing these APIs are meaning, metrics APIs are already a 
stable system, most systems don't need a complex internal mechanism to do that. 
Try to check those existing APIs, and make sure you have enough mechanisms to 
forward your metrics to their core. This should be better than doing these 
internally. After all, the metrics would not be managed, calculated, and 
visualized inside your project.
   
   Deeply thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to