yx91490 commented on a change in pull request #1089:
URL:
https://github.com/apache/incubator-seatunnel/pull/1089#discussion_r801744486
##########
File path:
seatunnel-connectors/seatunnel-connector-flink-jdbc/src/main/java/org/apache/seatunnel/flink/sink/JdbcSink.java
##########
@@ -94,20 +90,21 @@ public void prepare(FlinkEnvironment env) {
}
private void createSink(TableEnvironment tableEnvironment, Table table) {
- TypeInformation<?>[] fieldTypes = table.getSchema().getFieldTypes();
- String[] fieldNames = table.getSchema().getFieldNames();
- TableSink sink = JDBCAppendTableSink.builder()
- .setDrivername(driverName)
- .setDBUrl(dbUrl)
- .setUsername(username)
- .setPassword(password)
- .setBatchSize(batchSize)
- .setQuery(query)
- .setParameterTypes(fieldTypes)
- .build()
- .configure(fieldNames, fieldTypes);
- String uniqueTableName = SchemaUtil.getUniqueTableName();
- tableEnvironment.registerTableSink(uniqueTableName, sink);
- table.insertInto(uniqueTableName);
+ /* TypeInformation<?>[] fieldTypes =
table.getSchema().getFieldTypes();
+ String[] fieldNames = table.getSchema().getFieldNames();
+ TableSink sink = JDBCAppendTableSink.builder()
+ .setDrivername(driverName)
+ .setDBUrl(dbUrl)
+ .setUsername(username)
+ .setPassword(password)
+ .setBatchSize(batchSize)
+ .setQuery(query)
+ .setParameterTypes(fieldTypes)
+ .build()
+ .configure(fieldNames, fieldTypes);
+ String uniqueTableName = SchemaUtil.getUniqueTableName();
+ tableEnvironment.registerTableSink(uniqueTableName, sink);
+ table.insertInto(uniqueTableName);
+ */
Review comment:
@leo65535 can you explain why comment these code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
