kezhenxu94 commented on a change in pull request #1387:
URL:
https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r819206480
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared
here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you
can add it yourself
Review comment:
Well, looks like my comment last night didn't successfully post out....
"Merge this first" is not a good practice in open source, from my
experience, merged codes are rarely reviewed again and discussed, we don't have
a deadline in open source so let's get things done completely (at least reach
to an concensus).
The issue here to me is that the plugin includes all dependencies from all
scopes, including test, provided, @asdf2014 did you try the option
[`excludedScopes`](https://www.mojohaus.org/license-maven-plugin/add-third-party-mojo.html#excludedScopes)
to exclude scopes `test`, `provided` dependencies?
And because of this, I suspect that there are more unnecessary dependencies
(`provided` scope) license added. Please overhaul these,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
