asdf2014 commented on pull request #1406:
URL: 
https://github.com/apache/incubator-seatunnel/pull/1406#issuecomment-1059958645


   <img width="1016" alt="" 
src="https://user-images.githubusercontent.com/8108788/156923877-458a4caa-3a37-433c-9948-6f2d5349db9b.png";>
   
   As you can see from above image, the log was missing the 
`commons-pool:commons-pool:1.6`, it caused by the maven plugin with the 
`sortArtifactByName` option was enabled. And it has been solved by 
https://github.com/apache/incubator-seatunnel/pull/1387 .
   
   By the way, because this change cannot fix the root cause, so it won't add 
the `commons-pool:commons-pool:1.6` license back, which is not the right way I 
think.
   
   - this pr doesn't add it back:
     
![image](https://user-images.githubusercontent.com/8108788/156924058-61cd73cd-e96f-4968-86ed-3e845f05cd1b.png)
   - the https://github.com/apache/incubator-seatunnel/pull/1387 pr dose add it 
back:
     
![image](https://user-images.githubusercontent.com/8108788/156924038-8605ffa6-b0cc-44a0-97b9-11c80bb968a5.png)
   
   Besides, I wouldn't recommend add too many map instances in script, since it 
is equal to add `licenseMerge` option of maven plugin by 
https://github.com/apache/incubator-seatunnel/pull/1408 , which is more ease to 
use.
   
   Anyway, thanks for your idea :smile:
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to