Rianico commented on a change in pull request #1459:
URL:
https://github.com/apache/incubator-seatunnel/pull/1459#discussion_r823440777
##########
File path:
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-kudu/src/main/scala/org/apache/seatunnel/spark/source/Kudu.scala
##########
@@ -36,7 +36,6 @@ class Kudu extends SparkBatchSource {
"kudu.table" -> config.getString("kudu_table"))
val ds = env.getSparkSession.read
- .format("org.apache.kudu.spark.kudu")
.options(mapConf)
.kudu
Review comment:
`format("kudu")` is implemented by `org.apache.kudu:kudu-spark2_2.11`.
But it only take affect from `1.9.0`, and earlier version will get an
`java.lang.ClassNotFoundException: kudu.DefaultSource` Exception.
And the version that I see in pom is `1.7.0` :
```xml
<kudu-spark.version>1.7.0</kudu-spark.version>
```
So it is better to use `kudu` function directly, we don't need to pay
attention about `format("kudu")` or `format("org.apache.kudu.spark.kudu")`.
Consider the situation if we have many spark options, the Kudu's official
code example may look not so clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
