BenJFan commented on a change in pull request #1475:
URL:
https://github.com/apache/incubator-seatunnel/pull/1475#discussion_r825977232
##########
File path:
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/ConfigBuilder.java
##########
@@ -102,6 +103,22 @@ private boolean checkIsStreaming() {
return
sourceConfigList.get(0).getString(PLUGIN_NAME_KEY).toLowerCase().endsWith("stream");
}
+ private boolean checkIsContainHive() {
+ List<? extends Config> sourceConfigList =
config.getConfigList(PluginType.SOURCE.getType());
+ for (Config c : sourceConfigList) {
+ if (c.getString(PLUGIN_NAME_KEY).toLowerCase().contains("hive")) {
+ return true;
+ }
+ }
+ List<? extends Config> sinkConfigList =
config.getConfigList(PluginType.SINK.getType());
+ for (Config c : sinkConfigList) {
+ if (c.getString(PLUGIN_NAME_KEY).toLowerCase().contains("hive")) {
+ return true;
+ }
+ }
+ return false;
+ }
+
Review comment:
> I also agree don't put this logic in ConfigBuilder, since you still
need to use this result in `SparkEnvironment`.
>
> It might be better to just modified code in `SparkEnvironment` and remove
the change of ConfigBuilder.
In flink, this config also need, but not support hive in flink at now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
