wuchunfu commented on pull request #1486: URL: https://github.com/apache/incubator-seatunnel/pull/1486#issuecomment-1068746100
> > @yx91490 Some operations are placed in the code, will it reduce the flexibility, for example, you need to add a parameter to directly modify the shell script, instead of modifying the java code > > can you explain what kind of parameter you should frequently modify the script? but whatever, I don't think it's a good practice. But anyway I feel that it is not a good practice to hard-code the command in the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
