CalvinKirs commented on a change in pull request #1536:
URL:
https://github.com/apache/incubator-seatunnel/pull/1536#discussion_r833005024
##########
File path: pom.xml
##########
@@ -80,6 +80,7 @@
<module>seatunnel-connectors</module>
<module>seatunnel-dist</module>
<module>seatunnel-examples</module>
+ <module>seatunnel-e2e</module>
Review comment:
That's better. For most people, if the local UT can't run quickly, then
they may lose the ability to continue running the UT to verify the overall
correctness of this change. We should keep the UT lightweight. So I suggest
starting a separate e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
