asdf2014 commented on a change in pull request #1539:
URL:
https://github.com/apache/incubator-seatunnel/pull/1539#discussion_r833532568
##########
File path:
seatunnel-core/seatunnel-core-flink/src/main/bin/start-seatunnel-flink.sh
##########
@@ -35,7 +35,7 @@ fi
is_exist() {
if [ -z $1 ]; then
usage
- exit -1
+ exit 1
Review comment:
@ruanwenjun No, 1 is better. It reminds users this requires option. And
the original -1 also means error, which is same as 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
