CalvinKirs commented on a change in pull request #1562:
URL:
https://github.com/apache/incubator-seatunnel/pull/1562#discussion_r835054850
##########
File path:
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-doris/src/main/java/org/apache/seatunnel/flink/sink/DorisStreamLoad.java
##########
@@ -104,7 +104,7 @@ public void load(String value) {
private LoadResponse loadBatch(String data) {
String formatDate = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new
Date());
String label = String.format("flink_sink_%s_%s", formatDate,
- UUID.randomUUID().toString().replaceAll("-", ""));
+ UUID.randomUUID().toString().replace("-", ""));
Review comment:
String::replace does exactly the same thing as String::replaceAll
without the performance drawback of the regex. just personal habit, , but there
is no difference here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
