[incubator-seatunnel] branch dev updated: [Improve][Connectors]Refactor es config class (#1594)

[kirs]

This is an automated email from the ASF dual-hosted git repository.

kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 11b1d18  [Improve][Connectors]Refactor es config class (#1594)
11b1d18 is described below

commit 11b1d1832affd3ef3663a494c9bf7a696af2ac5c
Author: Kirs <k...@apache.org>
AuthorDate: Mon Mar 28 16:24:54 2022 +0800

    [Improve][Connectors]Refactor es config class (#1594)
    
    The constant interface pattern is a poor use of interfaces.
    Utility classes should not have public constructors
---
 .../org/apache/seatunnel/common/config/Common.java |  4 ++++
 .../src/main/java/org/apache/seatunnel/Config.java | 22 +++++++++++++---------
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git 
a/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java 
b/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java
index b8cc45d..777054a 100644
--- 
a/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java
+++ 
b/seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java
@@ -27,6 +27,10 @@ import java.util.stream.Collectors;
 
 public class Common {
 
+    private Common() {
+        throw new IllegalStateException("Utility class");
+    }
+
     private static final List<String> ALLOWED_MODES = 
Arrays.stream(DeployMode.values())
         .map(DeployMode::getName).collect(Collectors.toList());
 
diff --git 
a/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-elasticsearch/src/main/java/org/apache/seatunnel/Config.java
 
b/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-elasticsearch/src/main/java/org/apache/seatunnel/Config.java
index 84e7ab8..67af323 100644
--- 
a/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-elasticsearch/src/main/java/org/apache/seatunnel/Config.java
+++ 
b/seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-elasticsearch/src/main/java/org/apache/seatunnel/Config.java
@@ -20,46 +20,50 @@ package org.apache.seatunnel;
 /**
  * ElasticSearch sink configuration options
  */
-public interface Config {
+public final class Config {
+
+    private Config() {
+        throw new IllegalStateException("Utility class");
+    }
 
     /**
      * Parallelism of sink
      */
-    String PARALLELISM = "parallelism";
+    public static final String PARALLELISM = "parallelism";
 
     /**
      * ElasticSearch index
      */
-    String INDEX = "index";
+    public static final String INDEX = "index";
 
     /**
      * ElasticSearch index type
      */
-    String INDEX_TYPE = "index_type";
+    public static final String INDEX_TYPE = "index_type";
 
     /**
      * ElasticSearch index time format
      */
-    String INDEX_TIME_FORMAT = "index_time_format";
+    public static final String INDEX_TIME_FORMAT = "index_time_format";
 
     /**
      * ElasticSearch hosts (separated by commma)
      */
-    String HOSTS = "hosts";
+    public static final String HOSTS = "hosts";
 
     /**
      * Default index type
      */
-    String DEFAULT_INDEX_TYPE = "log";
+    public static final String DEFAULT_INDEX_TYPE = "log";
 
     /**
      * Default index name
      */
-    String DEFAULT_INDEX = "seatunnel";
+    public static final String DEFAULT_INDEX = "seatunnel";
 
     /**
      * Default index time format
      */
-    String DEFAULT_INDEX_TIME_FORMAT = "yyyy.MM.dd";
+    public static final String DEFAULT_INDEX_TIME_FORMAT = "yyyy.MM.dd";
 
 }