ruanwenjun commented on a change in pull request #1600:
URL:
https://github.com/apache/incubator-seatunnel/pull/1600#discussion_r836428350
##########
File path:
seatunnel-apis/seatunnel-api-spark/src/main/java/org/apache/seatunnel/spark/SparkEnvironment.java
##########
@@ -47,8 +47,6 @@
private boolean enableHive = false;
- private JobMode jobMode;
-
Review comment:
Suggested don't remove this field, this field used to defined what the
job mode of this job(streaming, batch, sql...), this field is useful, although
it is not used in spark now.
Remove the setJobMode method in RuntimeEnv looks good to me, we don't need
to use this method, the jobMode should be set at prepare method. I would like
add `getJobMode` method in RuntimeEnv.
This part of refactoring may require a separate PR to complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
