zhongjiajie commented on a change in pull request #1620:
URL:
https://github.com/apache/incubator-seatunnel/pull/1620#discussion_r838147769
##########
File path: .asf.yaml
##########
@@ -35,6 +35,13 @@ github:
dev:
required_status_checks:
strict: true
+ context:
+ - check-license
+ - CheckDeadLinks
+ - Build
+ - Spark
+ - Build (8)
+ - Build (11)
Review comment:
I think we should add the final step to determine all versions build
success, it will make our CI rubust because we may add other JDK supported. You
could find examples
inhttps://github.com/apache/dolphinscheduler/blob/dev/.github/workflows/e2e.yml#L141-L154.
Others look good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
