kezhenxu94 commented on code in PR #1585:
URL:
https://github.com/apache/incubator-seatunnel/pull/1585#discussion_r846721598
##########
seatunnel-core/seatunnel-core-spark/src/main/bin/start-seatunnel-spark.sh:
##########
@@ -174,7 +174,7 @@ echo "[INFO] spark conf: ${sparkconf}"
driverJavaOpts=""
executorJavaOpts=""
clientModeDriverJavaOpts=""
-if [ ! -z "${variables_substitution}" ]; then
+if [ -n "${variables_substitution}" ]; then
Review Comment:
`! -z` and `-n` are not equivalent.
Try this
```shell
foo="";
[ -n "$foo" ] && echo "foo is not null"
[ -z "$foo" ] && echo "foo is null"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
