1996fanrui commented on code in PR #1287:
URL:
https://github.com/apache/incubator-seatunnel/pull/1287#discussion_r856886182
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-druid/src/main/java/org/apache/seatunnel/flink/sink/DruidOutputFormat.java:
##########
@@ -56,7 +56,7 @@
import java.util.Arrays;
import java.util.Collections;
-public class DruidOutputFormat extends RichOutputFormat<Row> {
+public class DruidOutputFormat<T> extends RichOutputFormat<T> {
Review Comment:
From the writeRecord, we can see it just support Row, why add the `<T>` for
DruidOutputFormat? Could you revert this change? If no, please add some
details, thanks.
I think this change will delay the Error until writeRecord. And it just
log.ERROR, flink job will run normally, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
