ruanwenjun commented on code in PR #1742:
URL:
https://github.com/apache/incubator-seatunnel/pull/1742#discussion_r857561314
##########
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/command/FlinkCommandArgs.java:
##########
@@ -20,8 +20,14 @@
import org.apache.seatunnel.common.config.DeployMode;
import org.apache.seatunnel.config.EngineType;
+import com.beust.jcommander.Parameter;
+
public class FlinkCommandArgs extends AbstractCommandArgs {
+ @Parameter(names = {"--application-mode"},
+ description = "run job in application mode")
+ private boolean isApplicationMode = false;
Review Comment:
We only need to use `executeMode` to distinguish `run/run-application`.
These means you only need to add two subType of `executeMode` enum, if you want
to use enum.
I think this way is more scalable, if we need to add another type like
`run-xx` in the future. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
