legendtkl commented on code in PR #1742:
URL:
https://github.com/apache/incubator-seatunnel/pull/1742#discussion_r857672403
##########
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/command/FlinkCommandArgs.java:
##########
@@ -20,8 +20,14 @@
import org.apache.seatunnel.common.config.DeployMode;
import org.apache.seatunnel.config.EngineType;
+import com.beust.jcommander.Parameter;
+
public class FlinkCommandArgs extends AbstractCommandArgs {
+ @Parameter(names = {"-r", "--run-mode"},
+ description = "job run mode, run or run-application")
+ private String runMode;
Review Comment:
@ruanwenjun I think optional will be a better user experience, as we
already set the default value.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
